The ScriptsMiddleware(s) should be replaced by endpoints #15629
Milestone
Comments
This was referenced Apr 1, 2024
|
The endpoints in the Content module can serve as examples. |
|
Is this issue still open? I was thinking about picking it up as a first issue if so, I wanted to check first since I do not see any references to OrchardCore.Liquid.ScriptsMiddleWare Forgive my ignorance and thank you for the help. |
|
You can go for it |
|
Yep, thank you! Be sure to check out https://docs.orchardcore.net/en/latest/guides/contributing/contributing-code/ first. |
|
My progress has been slow, I don't think I can complete it in a reasonable amount of time 😅. My sincere apologies. |
|
Perhaps try to follow the pattern of #15294. This should be more or less copy-pasting to endpoints from the middlewares. |
DonaldDWebster
pushed a commit
to DonaldDWebster/OrchardCore
that referenced
this issue
Oct 13, 2024
DonaldDWebster
added a commit
to DonaldDWebster/OrchardCore
that referenced
this issue
Oct 13, 2024
DonaldDWebster
added a commit
to DonaldDWebster/OrchardCore
that referenced
this issue
Oct 18, 2024
DonaldDWebster
added a commit
to DonaldDWebster/OrchardCore
that referenced
this issue
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No need to create a middleware that is impacting the stack size to serve script files. We can register the endpoint routes directly and invoke a delegate.
These methods should also not do string concatenation to render the files. They could precompute the utf8 string (
private static ReadOnlySpan<byte> => "value"u8;) and callWriteAsync()for each segment instead.The text was updated successfully, but these errors were encountered: