Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added home page to dashboard sample #41

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brunoAltinet
Copy link

I've added a nicer homepage that showcases module and admin functionalities after setup is complete

@brunoAltinet
Copy link
Author

@agriffard @MikeAlhayek

@MikeAlhayek
Copy link
Member

Shouldn't you then remove line 40-51 from here then? https://github.com/OrchardCMS/OrchardCore.Samples/blob/main/DashboardApplication/Program.cs

If Page/Index is handled by default that's all you would need. I still need to investigate why can't we define routes in the web project in addition to the area routes.

@brunoAltinet
Copy link
Author

Shouldn't you then remove line 40-51 from here then? https://github.com/OrchardCMS/OrchardCore.Samples/blob/main/DashboardApplication/Program.cs

If Page/Index is handled by default that's all you would need. I still need to investigate why can't we define routes in the web project in addition to the area routes.

Correct, removed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants