Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC-302: Fix Serializing the Region type using System.Text.Json throws an exception #504

Merged
merged 9 commits into from
Oct 9, 2024
Merged

OCC-302: Fix Serializing the Region type using System.Text.Json throws an exception #504

merged 9 commits into from
Oct 9, 2024

Conversation

sarahelsaig
Copy link
Contributor

@sarahelsaig sarahelsaig commented Oct 8, 2024 •
edited by github-actions bot
Loading

OCC-302
Fixes #503

@wAsnk
Copy link
Contributor

wAsnk commented Oct 9, 2024

I'm not sure what's going on with the tests but it seems like there is a failing one without failing the tests?
OrderEditorShouldWorkProperly shows up as failed in the summary:
image

But not here:
image

@sarahelsaig
Copy link
Contributor Author

I'm not sure what's going on with the tests but it seems like there is a failing one without failing the tests?

The tests were awaited, but did not throw on failure. Fixed now.

@wAsnk wAsnk merged commit a7d95ac into main Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wAsnk wAsnk wAsnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serializing the Region type using System.Text.Json throws an exception. (OCC-302)
3 participants
@sarahelsaig @wAsnk @LombiqBot