Pass PaymentIntentId to Client for convenience of API calling #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahelsaig
reviewed
Sep 6, 2024
src/Modules/OrchardCore.Commerce.Payment.Stripe/Abstractions/IStripePaymentService.cs
Outdated
Show resolved
Hide resolved
hishamco
reviewed
Sep 6, 2024
| ) | ||
| { | ||
| // If it is null it means the session was not loaded yet and a redirect is needed. | ||
| if (string.IsNullOrEmpty(_paymentIntentPersistence.Retrieve())) | ||
| if (needToJudgeIntentStorage && string.IsNullOrEmpty(_paymentIntentPersistence.Retrieve())) |
There was a problem hiding this comment.
What if we check the paymentIntent existence instead of introducing a new param?
There was a problem hiding this comment.
in your way, it is not flexible。 actually use needToJudgeIntentStorage can pass by the whole _paymentIntentPersistence system, which means I do not need _paymentIntentPersistence for store and retrieve.
and the new _paymentIntentPersistence does not influence the current code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #490