Update OC 1.8.3 #435
Update OC 1.8.3 #435
Conversation
| <PackageVersion Include="OrchardCore.Templates" Version="1.8.2" /> | ||
| <PackageVersion Include="OrchardCore.Title" Version="1.8.2" /> | ||
| <PackageVersion Include="OrchardCore.Workflows.Abstractions" Version="1.8.2" /> | ||
| <PackageVersion Include="OrchardCore.Application.Cms.Targets" Version="1.8.3" /> |
There was a problem hiding this comment.
I think the OCC packages should always target the .0 minor version of the latest version; i.e., 1.8.0 in this case, so people can use the packages regardless of them being on 1.8.0, 1.8.1, 1.8.2, or 1.8.3 (currently they're forced to use at least 1.8.2). During development and testing though, we should use the very latest, if somehow this can be done. @sarahelsaig what do you think?
There was a problem hiding this comment.
Sometimes, the patch version fixes a few bugs which is good to bump to the latest
There was a problem hiding this comment.
Yes, but that's not what I'm talking about.
There was a problem hiding this comment.
Ah, got it now you were referring to OCC :)
There was a problem hiding this comment.
Good idea, @Piedone!
At first I was going to suggest using VersionOverride, but on second thought it would be cleaner to define a variable in the <PropertyGroup> above like:
<PropertyGroup>
...
<OrchardCoreVersion Condition="'$(NuGetBuild)' == 'true'">1.8.0</OrchardCoreVersion>
<OrchardCoreVersion Condition="'$(NuGetBuild)' != 'true'">1.8.3</OrchardCoreVersion>
</PropertyGroup>
<ItemGroup>
...
<PackageVersion Include="OrchardCore.Application.Cms.Targets" Version="$(OrchardCoreVersion)" />
<PackageVersion Include="OrchardCore.ContentFields" Version="$(OrchardCoreVersion)" />
...
</ItemGroup>The added bonus here is that going forward we will only have to change either one or two lines on a version upgrade instead of 16.
There was a problem hiding this comment.
Turns out Lombiq.HelpfulLibraries requires OC 1.8.2 so for now this won't work but I'd like to revisit the idea after this: Lombiq/Helpful-Libraries#258
Also it looks like the Lombiq.* NuGet packages actually export the NuGetBuild symbol? This is very strange.
There was a problem hiding this comment.
That's because of https://github.com/Lombiq/GitHub-Actions/pull/343/files#diff-96e58ab979bf1e8b7d14178a048ebbe8901f627c6e3daf9abfcfe88d93f1282b. I'm fixing it.
https://github.com/OrchardCMS/OrchardCore/releases/tag/v1.8.3