OCC-218: Update NuGet packages and migrate to centralized package management #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
This comment has been minimized.
This comment has been minimized.
Piedone
requested changes
Feb 21, 2024
test/OrchardCore.Commerce.Tests.UI/OrchardCore.Commerce.Tests.UI.csproj
Outdated
Show resolved
Hide resolved
sarahelsaig
added
done-jira-issue-if-checks-succeed
and removed
done-jira-issue-if-checks-succeed
labels
# Conflicts: # Directory.Build.props # src/Libraries/OrchardCore.Commerce.Abstractions/OrchardCore.Commerce.Abstractions.csproj # src/Modules/OrchardCore.Commerce.ContentFields/OrchardCore.Commerce.ContentFields.csproj # src/Modules/OrchardCore.Commerce.Inventory/OrchardCore.Commerce.Inventory.csproj # src/Modules/OrchardCore.Commerce.Payment.Stripe/OrchardCore.Commerce.Payment.Stripe.csproj # src/Modules/OrchardCore.Commerce.Payment/OrchardCore.Commerce.Payment.csproj # src/Modules/OrchardCore.Commerce.Promotion/OrchardCore.Commerce.Promotion.csproj # src/Modules/OrchardCore.Commerce.Tax/OrchardCore.Commerce.Tax.csproj # src/Modules/OrchardCore.Commerce/OrchardCore.Commerce.csproj # src/OrchardCore.Commerce.Web/OrchardCore.Commerce.Web.csproj # test/OrchardCore.Commerce.Tests.UI.Shortcuts/OrchardCore.Commerce.Tests.UI.Shortcuts.csproj # test/OrchardCore.Commerce.Tests.UI/OrchardCore.Commerce.Tests.UI.csproj # test/OrchardCore.Commerce.Tests/OrchardCore.Commerce.Tests.csproj
Piedone
requested changes
Feb 28, 2024
test/OrchardCore.Commerce.Tests.UI/Tests/BasicTests/SecurityScanningTests.cs
Outdated
Show resolved
Hide resolved
sarahelsaig
added a commit
that referenced
this pull request
Feb 29, 2024
* Upgrading TargetFramework and OC versions. * Making Migrations Async. * Updating Analyzers. * Making Service methods async and addressing warnings. * More ToAsync changes. * Fixing method implementation. * Even morer Async fixes. * Addressing warnings. * Addressing warnings. * More warnings. * Fixing tests. * Fixing tests. * Fixing nuget versions. * Consolidating packages. * Fixing test. * Fixing tests. * OCC-218: Update NuGet packages and migrate to centralized package management (#410) * Using SuppressMessage. * Removing Attribute. --------- Co-authored-by: Sára El-Saig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCC-218
Since this project will never have submodules it makes sense to use Directory.Packages.props and get rid of the tedium of upgrading each csproj individually. Going forward we'll only have more project files so it's best to do it now than later.
Fixes #404