Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC-186: Product Image #352

Merged
merged 12 commits into from
Sep 23, 2023
Merged

OCC-186: Product Image #352

merged 12 commits into from
Sep 23, 2023

Conversation

DemeSzabolcs
Copy link
Contributor

@DemeSzabolcs DemeSzabolcs commented Sep 17, 2023 •
edited by github-actions bot
Loading

OCC-186
Fixes #344

sarahelsaig
sarahelsaig requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@sarahelsaig sarahelsaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a test when possible. In this case you can expand the existing RetrievalProductTests.HomePageShouldBeProductList test.

src/Modules/OrchardCore.Commerce/Migrations/ProductMigrations.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Migrations/ProductMigrations.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Recipes/OrchardCore.Commerce.Samples.Product.recipe.json Outdated Show resolved Hide resolved
@sarahelsaig sarahelsaig merged commit 778ca53 into main Sep 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product Image (OCC-186)
3 participants
@DemeSzabolcs @sarahelsaig @LombiqBot