OCC-52: No Payment Needed Checkout #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porgabi
commented
Jul 27, 2023
porgabi
commented
Jul 27, 2023
sarahelsaig
requested changes
Jul 29, 2023
src/Modules/OrchardCore.Commerce/Abstractions/IStripePaymentService.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Abstractions/IStripePaymentService.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Controllers/PaymentController.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Services/StripePaymentService.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Services/StripePaymentService.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Services/StripePaymentService.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Services/StripePaymentService.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Services/StripePaymentService.cs
Outdated
Show resolved
Hide resolved
sarahelsaig
requested changes
Jul 30, 2023
| order.As<OrderPart>().ShippingAddress.Address, | ||
| order.As<OrderPart>().BillingAddress.Address); | ||
|
|
||
| if (!cartViewModel.Totals.Any() || cartViewModel.Totals.Sum().Value != 0) |
There was a problem hiding this comment.
.Sum() is not appropriate here, because one of the possible reasons why you'd have multiple totals is if they are in different currencies. In this case the will throw InvalidOperationException.
Rather use cartViewModel.Totals.Any()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCC-52
Fixes #13