OCC-163: PriceVariantsPart doesn't support InventoryPart #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
porgabi
commented
Jul 21, 2023
| var inventory = part.Inventory ?? new Dictionary<string, int>(); | ||
| if (inventory.Any()) | ||
| { | ||
| // Workaround for InventoryPart storing the outdated inventory entries along with the updated ones. |
There was a problem hiding this comment.
The InventoryKeys list property is used as a workaround to the incorrectly working dictionary property. For some reason, list properties do not retain cleared values (which is working as intended), while dictionaries do.
This comment has been minimized.
This comment has been minimized.
Psichorex
requested changes
Jul 22, 2023
src/Modules/OrchardCore.Commerce.Inventory/Drivers/InventoryPartDisplayDriver.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce.Inventory/Views/InventoryPart.Edit.cshtml
Show resolved
Hide resolved
| { | ||
| part.CanBeBought.Clear(); | ||
|
|
||
| var correctInventory = inventoryPart.Inventory |
There was a problem hiding this comment.
This invertory correction could be extraced into a method and use that in multiple places.
src/Modules/OrchardCore.Commerce/Views/TextProductAttributeField.cshtml
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Views/TextProductAttributeField.cshtml
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce/Views/TextProductAttributeField.cshtml
Outdated
Show resolved
Hide resolved
Psichorex
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCC-163
Fixes #302