Fixing null issue

OrchardCMS · Oct 31, 2024 · babd6ec · babd6ec
1 parent 7225adb
commit babd6ec
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/Modules/OrchardCore.Commerce.Payment/Endpoints/Api/PaymentEndpoint.cs b/src/Modules/OrchardCore.Commerce.Payment/Endpoints/Api/PaymentEndpoint.cs
@@ -60,14 +60,14 @@ [FromServices] IPaymentService paymentService
             return httpContext.ChallengeOrForbidApi();
         }
 
-        if (viewModel.PaymentProviderName.EqualsOrdinalIgnoreCase("Stripe"))
+        if (viewModel.PaymentProviderName == null)
         {
-            return TypedResults.BadRequest("Stripe payment uses ~/checkout/stripe/middleware, not ~/checkout/callback/Stripe.");
+            return TypedResults.BadRequest($"${nameof(AddCallbackViewModel.PaymentProviderName)} is required.");
         }
 
-        if (string.IsNullOrWhiteSpace(viewModel.OrderId))
+        if (viewModel.PaymentProviderName.EqualsOrdinalIgnoreCase("Stripe"))
         {
-            viewModel.OrderId = null;
+            return TypedResults.BadRequest("Stripe payment uses ~/checkout/stripe/middleware, not ~/checkout/callback/Stripe.");
         }
 
         if (await paymentService.CallBackAsync(

diff --git a/src/Modules/OrchardCore.Commerce.Payment/Endpoints/Models/AddCallbackViewModel.cs b/src/Modules/OrchardCore.Commerce.Payment/Endpoints/Models/AddCallbackViewModel.cs
@@ -1,8 +1,11 @@
-namespace OrchardCore.Commerce.Payment.Endpoints.Models;
+using System.ComponentModel.DataAnnotations;
+
+namespace OrchardCore.Commerce.Payment.Endpoints.Models;
 
 public class AddCallbackViewModel
 {
-    public string PaymentProviderName { get; set; }
+    [Required]
+    public string? PaymentProviderName { get; set; }
     public string? OrderId { get; set; }
     public string? ShoppingCartId { get; set; }
 }