Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

307 datazoom not displayed correctly #396

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

jacques-lebourgeois
Copy link
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#307

Description

  • Fix the bug
  • Add an example

Motivation & Context

Sliders are not visibles when using datazoom echarts functionnality

Types of change

  • Bug fix (non-breaking which fixes an issue)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@jacques-lebourgeois jacques-lebourgeois linked an issue Nov 4, 2024 that may be closed by this pull request
3 tasks
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit bcc5bdd
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/672cd3128748c600087dc679
😎 Deploy Preview https://deploy-preview-396--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacques-lebourgeois jacques-lebourgeois force-pushed the 307-datazoom-not-displayed-correctly branch from 3a9210f to 4fa7dda Compare November 4, 2024 18:45
@jacques-lebourgeois jacques-lebourgeois added bug Something isn't working documentation Improvements or additions to documentation labels Nov 4, 2024
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not linked to this PR, but clicking on these buttons in the example page doesn't work. Might probably fixed in a follow-up PR.

Screenshot 2024-11-07 at 15 28 10

Unexpected value matrix(NaN,NaN,NaN,NaN,NaN,NaN) parsing transform attribute.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) I let @louismaximepiton review it as well if needed. Otherwise, you can merge and re-release an alpha

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with it 🙏 thanks ❤️

@jacques-lebourgeois jacques-lebourgeois merged commit 1f46cd0 into main Nov 13, 2024
5 checks passed
@jacques-lebourgeois jacques-lebourgeois deleted the 307-datazoom-not-displayed-correctly branch November 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datazoom not displayed correctly
3 participants