Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store handler return value #209

Merged
merged 5 commits into from
Nov 23, 2015

Conversation

albertjan
Copy link

Follow up to #178.

Because I don't have access to the other repo anymore.

@albertjan
Copy link
Author

_saveAttempt is never called with a stacktrace. @evanhuang8 can that be cleaned up?

@evanhuang8
Copy link
Contributor

Yeah now that I look at it it's actually wrong, must be a refactor error. _saveAttempt should not expect an argument, and the checking should check this.stacktrace instead of stacktrace

@albertjan
Copy link
Author

@evanhuang8 I updated it 😄

@evanhuang8
Copy link
Contributor

@albertjan thank you, that was some shitty code I wrote lol

@albertjan
Copy link
Author

@evanhuang8 you are forgiven 😄 you did a lot of good work for bull lately.

manast added a commit that referenced this pull request Nov 23, 2015
@manast manast merged commit 44b60db into OptimalBits:master Nov 23, 2015
@evanhuang8
Copy link
Contributor

@manast it will be nice to have an updated version on npm soon, since the stacktrace thing is quite useful

@TylerBrock
Copy link

yeah, absolutely, would it be too much to ask for you cut a release as well?

@manast
Copy link
Member

manast commented Nov 28, 2015

New release 0.7.0

@kimmobrunfeldt
Copy link

Hi guys, if I understood correctly this PR could help me with my issue. Could you shortly explain how would I use this new feature to get the return value of a job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants