Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigNumber comparison improved #1581

Merged
merged 24 commits into from
Jan 4, 2019
Merged

BigNumber comparison improved #1581

merged 24 commits into from
Jan 4, 2019

Conversation

Aniket-Engg
Copy link
Contributor

Fixes #204

frangio
frangio reviewed Jan 2, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @Aniket-Engg! Thanks.

test/token/ERC721/ERC721.behavior.js Show resolved Hide resolved
contracts/mocks/SafeERC20Helper.sol Outdated Show resolved Hide resolved
@frangio frangio self-assigned this Jan 2, 2019
@frangio
Copy link
Contributor

frangio commented Jan 3, 2019

Sorry @Aniket-Engg, we misunderstood; I'd rather keep the deep comparison for now so I added it back.

@frangio frangio merged commit 350aae0 into OpenZeppelin:master Jan 4, 2019
@frangio
Copy link
Contributor

frangio commented Jan 4, 2019

Thanks @Aniket-Engg!

@Aniket-Engg Aniket-Engg deleted the fix/#204 branch January 5, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees

@frangio frangio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aniket-Engg @frangio