Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:import for latest workshop #144

Merged
merged 10 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,7 @@ jobs:
- name: Run unittests
run: |
pytest --cov=ovos_plugin_common_play --cov-report xml test/unittests
# NOTE: additional pytest invocations should also add the --cov-append flag
# or they will overwrite previous invocations' coverage reports
# (for an example, see OVOS Skill Manager's workflow)
- name: Run unittests with ovos-utils 0.0.38
run: |
pip install ovos-utils==0.0.38
pytest --cov=ovos_plugin_common_play --cov-report xml test/unittests
- name: Upload coverage
env:
CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}}
uses: codecov/codecov-action@v2
uses: codecov/codecov-action@v2
2 changes: 1 addition & 1 deletion ovos_plugin_common_play/ocp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

from padacioso import IntentContainer

from ovos_workshop import OVOSAbstractApplication
from ovos_workshop.app import OVOSAbstractApplication
from ovos_workshop.decorators.ocp import *
from ovos_plugin_manager.ocp import load_stream_extractors

Expand Down
2 changes: 1 addition & 1 deletion ovos_plugin_common_play/ocp/media.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from ovos_bus_client.message import Message
from ovos_utils.json_helper import merge_dict
from ovos_utils.log import LOG
from ovos_workshop.backwards_compat import MediaState, TrackState, PlaybackType, MediaType, Playlist, PluginStream, MediaEntry as _ME
from ovos_utils.ocp import MediaState, TrackState, PlaybackType, MediaType, Playlist, PluginStream, MediaEntry as _ME

from ovos_plugin_common_play.ocp.constants import OCP_ID
from ovos_plugin_common_play.ocp.utils import ocp_plugins
Expand Down
2 changes: 1 addition & 1 deletion ovos_plugin_common_play/ocp/mpris.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from dbus_next.service import ServiceInterface, method, dbus_property, PropertyAccess
from ovos_bus_client.message import Message
from ovos_utils.log import LOG
from ovos_workshop.decorators.ocp import TrackState, PlaybackType, PlayerState, LoopState
from ovos_utils.ocp import TrackState, PlaybackType, PlayerState, LoopState


class MprisPlayerCtl(Thread):
Expand Down
9 changes: 3 additions & 6 deletions ovos_plugin_common_play/ocp/player.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
from ovos_config import Configuration
from ovos_utils.log import LOG
from ovos_utils.messagebus import Message
from ovos_workshop import OVOSAbstractApplication
from ovos_workshop.backwards_compat import (PluginStream, LoopState, MediaState, PlayerState, TrackState,
from ovos_workshop.app import OVOSAbstractApplication
from ovos_utils.ocp import (PluginStream, LoopState, MediaState, PlayerState, TrackState, dict2entry,
PlaybackType, MediaEntry, PlaybackMode, Playlist)

from ovos_plugin_common_play.ocp.constants import OCP_ID
Expand All @@ -17,10 +17,7 @@
from ovos_bus_client.apis.ocp import ClassicAudioServiceInterface
from ovos_plugin_common_play.ocp.search import OCPSearch
from ovos_plugin_common_play.ocp.utils import require_native_source
try:
from ovos_utils.ocp import dict2entry
except ImportError: # older utils version
dict2entry = MediaEntry.from_dict



class OCPMediaPlayer(OVOSAbstractApplication):
Expand Down
2 changes: 1 addition & 1 deletion ovos_plugin_common_play/ocp/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from ovos_bus_client.message import Message
from ovos_utils.log import LOG
from ovos_workshop.decorators.ocp import MediaType
from ovos_utils.ocp import MediaType

from ovos_plugin_common_play.ocp.base import OCPAbstractComponent
from ovos_plugin_common_play.ocp.media import Playlist
Expand Down
4 changes: 2 additions & 2 deletions ovos_plugin_common_play/ocp/status.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
from ovos_workshop.decorators.ocp import *
from ovos_plugin_common_play.ocp.constants import OCP_ID
from ovos_utils.ocp import *
from ovos_plugin_common_play.ocp.constants import OCP_ID
2 changes: 1 addition & 1 deletion requirements/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ovos-plugin-manager>=0.0.26,<1.0.0
ovos_bus_client>=0.0.7,<1.0.0
ovos-utils>=0.0.38,<1.0.0
ovos-utils>=0.1.0,<1.0.0
ovos-workshop>=0.0.16,<2.0.0
padacioso>=0.1.1,<1.0.0
dbus-next
Loading