Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/OCP_plugins_loading #103

Merged
merged 3 commits into from
Dec 30, 2023
Merged

fix/OCP_plugins_loading #103

merged 3 commits into from
Dec 30, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 30, 2023

OCP plugins load in every service (eg, core) even when not used, this is because they are a module property

this makes them ONLY load in OCP, instead of everytime OCP is imported

OCP plugins load in every service even when not used, this is because they are a module property

this makes them ONLY load in OCP, instead of everytime OPM is imported
@JarbasAl JarbasAl added the bug Something isn't working label Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@6a2a758). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #103   +/-   ##
======================================
  Coverage       ?   52.69%           
======================================
  Files          ?       14           
  Lines          ?     2655           
  Branches       ?        0           
======================================
  Hits           ?     1399           
  Misses         ?     1256           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 796b3f5 into dev Dec 30, 2023
5 checks passed
@JarbasAl JarbasAl deleted the fix/OCP_plugins_loading branch December 30, 2023 01:43
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant