204 is fine for a status code

OpenShock · Oct 29, 2024 · 99e9f5b · 99e9f5b
1 parent c4f8a0c
commit 99e9f5b
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 15 deletions.
diff --git a/src/views/dashboard/ApiTokens/ApiTokenRoot.vue b/src/views/dashboard/ApiTokens/ApiTokenRoot.vue
@@ -163,7 +163,7 @@ export default {
                 preConfirm: async () => {
                     try {
                         const res = await apiCall.makeCall('DELETE', `1/tokens/${item.id}`);
-                        if (res.status !== 200) {
+                        if (res.status !== 200 && res.status !== 204) {
                             throw new Error(res);
                         }
 
@@ -187,7 +187,7 @@ export default {
                 name: this.editing.token.name,
 
             });
-            if (res === undefined || res.status !== 200) {
+            if (res === undefined || res.status !== 200 && res.status !== 204) {
                 this.$swal('Error', 'Error while updating new token', 'error');
                 return;
             }

diff --git a/src/views/dashboard/devices/DevicesRoot.vue b/src/views/dashboard/devices/DevicesRoot.vue
@@ -155,7 +155,7 @@ export default {
         preConfirm: async () => {
           try {
             const res = await apiCall.makeCall('PUT', `1/devices/${item.id}`);
-            if (res.status !== 200) {
+            if (res.status !== 200 && res.status !== 204) {
               throw new Error(res.statusText);
             }
 
@@ -185,7 +185,7 @@ export default {
         preConfirm: async () => {
           try {
             const res = await apiCall.makeCall('DELETE', `1/devices/${item.id}`);
-            if (res.status !== 200) {
+            if (res.status !== 200 && res.status !== 204) {
               throw new Error(res.statusText);
             }
 
@@ -252,7 +252,7 @@ export default {
         name: this.editItem.name
       });
 
-      if (res === undefined || res.status !== 200) {
+      if (res === undefined || res.status !== 200 && res.status !== 204) {
         toastr.error("Error while updating device");
         return;
       }

diff --git a/src/views/dashboard/shares/links/ShareLinkShocker.vue b/src/views/dashboard/shares/links/ShareLinkShocker.vue
@@ -162,7 +162,7 @@ export default {
                 preConfirm: async () => {
                     try {
                         const res = await apiCall.makeCall('DELETE', `1/shares/links/${this.$route.params.id}/${this.shocker.id}`);
-                        if (res.status !== 200) {
+                        if (res.status !== 200 && res.status !== 204) {
                             throw new Error(res.statusText);
                         }
 

diff --git a/src/views/dashboard/shares/links/ViewShareLink.vue b/src/views/dashboard/shares/links/ViewShareLink.vue
@@ -154,7 +154,7 @@ export default {
         async addShockerAction() {
             if (!this.validateAddShocker) return;
             const res = await apiCall.makeCall('POST', `1/shares/links/${this.id}/${this.addShocker.selectedShocker}`);
-            if (res === undefined || res.status !== 200) {
+            if (res === undefined || res.status !== 200 && res.status !== 204) {
                 toastr.error("Error while adding shocker to share link");
                 return;
             }

diff --git a/src/views/dashboard/shockers/own/Own.vue b/src/views/dashboard/shockers/own/Own.vue
@@ -260,7 +260,7 @@ export default {
                 model: this.retrievedShocker.model
             });
 
-            if (res === undefined || res.status !== 200) {
+            if (res === undefined || res.status !== 200 && res.status !== 204) {
                 toastr.error("Error while updating shocker");
                 return;
             }

diff --git a/src/views/dashboard/shockers/own/OwnShocker.vue b/src/views/dashboard/shockers/own/OwnShocker.vue
@@ -199,7 +199,7 @@ export default {
                 preConfirm: async () => {
                     try {
                         const res = await apiCall.makeCall('DELETE', `1/shockers/${this.shocker.id}`);
-                        if (res.status !== 200) {
+                        if (res.status !== 200 && res.status !== 204) {
                             throw new Error(res.statusText);
                         }
 

diff --git a/src/views/dashboard/shockers/own/shares/ShockerSharesRoot.vue b/src/views/dashboard/shockers/own/shares/ShockerSharesRoot.vue
@@ -280,7 +280,7 @@ export default {
                 preConfirm: async () => {
                     try {
                         const res = await apiCall.makeCall('DELETE', `1/shares/code/${code.id}`);
-                        if (res.status !== 200) {
+                        if (res.status !== 200 && res.status !== 204) {
                             throw new Error(res);
                         }
 
@@ -319,7 +319,7 @@ export default {
                 preConfirm: async () => {
                     try {
                         const res = await apiCall.makeCall('DELETE', `1/shockers/${this.$route.params.id}/shares/${share.sharedWith.id}`);
-                        if (res.status !== 200) {
+                        if (res.status !== 200 && res.status !== 204) {
                             throw new Error(res);
                         }
 
@@ -358,7 +358,7 @@ export default {
                     intensity: temp.limitsTranslated.intensity == 100 ? null : temp.limitsTranslated.intensity
                 }
             });
-            if (res === undefined || res.status !== 200) {
+            if (res === undefined || res.status !== 200 && res.status !== 204) {
                 toastr.error("Error while creating share code");
                 return;
             }

diff --git a/src/views/dashboard/shockers/shared/Shared.vue b/src/views/dashboard/shockers/shared/Shared.vue
@@ -68,7 +68,7 @@ export default {
                 preConfirm: async (id) => {
                     try {
                         const res = await apiCall.makeCall('POST', `1/shares/code/${id}`);
-                        if (res.status !== 200) {
+                        if (res.status !== 200 && res.status !== 204) {
                             throw new Error(res.statusText);
                         }
                     } catch (err) {

diff --git a/src/views/dashboard/shockers/shared/SharedShocker.vue b/src/views/dashboard/shockers/shared/SharedShocker.vue
@@ -168,7 +168,7 @@ export default {
                 preConfirm: async () => {
                     try {
                         const res = await apiCall.makeCall('DELETE', `1/shockers/${this.shocker.id}/shares/${this.$store.state.user.id}`);
-                        if (res.status !== 200) {
+                        if (res.status !== 200 && res.status !== 204) {
                             throw new Error(res.statusText);
                         }
 

diff --git a/src/views/public/proxy/ShareCodeProxy.vue b/src/views/public/proxy/ShareCodeProxy.vue
@@ -33,7 +33,7 @@ export default {
 
         try {
             const res = await apiCall.makeCall('POST', `1/shares/code/${this.id}`);
-            if (res.status !== 200) {
+            if (res.status !== 200 && res.status !== 204) {
                 throw new Error(res.statusText);
             }
             toastr.success(`Failed to add share: ${utils.getError(err)}`);