Kernel opening should be provable and confirmed on auxiliary #448

deepesh-kn · 2018-11-05T06:31:04Z

fixes: #407
fixes: #408

As there is lot of cyclic interdependencies of the contract. I tried to avoid KernelGateway to be increase it. So there was a small change in flow. Now AuxiliaryBlockStore communicates with PollingPlace instead of KernelGateway.

Incase you do not agree with the flow. Lets discuss I can make a quick change.

Here is the flow.

a new kernel opens on origin
the origin state root that includes the new, open kernel is reported and finalized on auxiliary
anyone makes a Merkle proof of the open kernel in the KernelGateway
in the success case, the AuxiliaryBlockStore is informed that a new kernel opening was proven, AuxiliaryBlockStore stores the information about the kernel including the future validator sets
when the auxiliary dynasty increases the second time (d+2), the AuxiliaryBlockStore confirms the kernel opening
AuxiliaryBlockStore informs the PollingPlace about the new set of validators, and increase the meta-block height

The points that differs here are from the store are

KernelGateway informs the AuxiliaryBlockStore instead of PollingPlace about the future change in the set of validators.
When the auxiliary dynasty increases the second time (d+2), the metablock height and validators are updated in pollingplace. This is now called by auxiliaryBlockStore instead of KernelGateway.

There are interdependencies of the contracts. It is not resolved in this PR. So once it is resolved then function setKernelGateway(address _kernelGateway) should be removed from AuxiliaryBlockStore.sol

schemar · 2018-11-05T14:39:01Z

There are interdependencies of the contracts. It is not resolved in this PR. So once it is resolved then function setKernelGateway(address _kernelGateway) should be removed from AuxiliaryBlockStore.sol

Maybe add a follow-up ticket?

schemar

Very interesting 👍
I added some comments in-line. But someone who has more experience with the gateways definitely should review it. The most important part (KernelGateway) I could not check very thoroughly.

contracts/core/AuxiliaryBlockStore.sol

contracts/test/core/MockKernelGateway.sol

test/core/kernel_gateway/constructor.js

test/core/polling_place/updateMetaBlockHeight.js

test/core/auxiliary_block_store/reportOpenKernel.js

…to kernel gateway

…tion warnings

schemar

Thanks Deepesh! I still have some questions. And we should also wait for Sarvesh's feedback next week.

Note: Please end all doc comments with a period ..

contracts/core/AuxiliaryBlockStore.sol

contracts/core/KernelGatewayInterface.sol

contracts/lib/BytesLib.sol

contracts/test/core/BlockStoreMock.sol

test/core/auxiliary_block_store/is_vote_valid.js

test/core/polling_place/TestPollingPlace.sol

0xsarvesh

Overall approach looks correct to me. 👍 🚀

Some comments and feedback inline.

@deepesh-kn @schemar
We should re-think for circular dependency between contracts (Polling place -> Block store -> Kernel Gateway). Specifically for justify method call from PollingPlace to BlockStore.

contracts/core/KernelGateway.sol

test/core/kernel_gateway/activate_kernel.js

test/core/kernel_gateway/get_active_kernel_hash.js

test/core/kernel_gateway/get_open_kernel_hash.js

test/core/kernel_gateway/get_updated_validators.js

test/core/kernel_gateway/prove_block_opening.js

schemar

I have only tiny things left. Looks really good 🚤💨

contracts/core/AuxiliaryBlockStore.sol

contracts/core/BlockStore.sol

contracts/core/KernelGateway.sol

contracts/core/PollingPlace.sol

contracts/test/core/BlockStoreMock.sol

contracts/test/core/MockKernelGateway.sol

test/core/polling_place/TestPollingPlace.sol

…ctInterface.sol

schemar

There are still some small questions, please see in-line.

contracts/core/AuxiliaryTransitionObjectInterface.sol

contracts/core/BlockStore.sol

contracts/core/OriginTransitionObjectInterface.sol

schemar

🏎💨

0xsarvesh

LGTM 🚀 🚁 🥇 🙌

Great work 😄

Deepesh Kumar Nath added 6 commits October 31, 2018 17:35

Renamed MetaBlockGatewayInterface to KernelGatewayInterface

7ab07e9

Happy case

e9dc088

Added tests

828dff4

Deleted unused files

abdce8e

Removed kernel gateway address fromm the polling place constructor

d8601e6

Added getMetaBlockHash function

981248f

deepesh-kn requested review from schemar and 0xsarvesh November 5, 2018 06:32

Merge remote-tracking branch 'upstream/develop' into gh_407

94ec37e

schemar reviewed Nov 5, 2018

View reviewed changes

Removed kernel related logic from auxiliary block store and moved it …

7544f45

…to kernel gateway

schemar assigned deepesh-kn Nov 6, 2018

Deepesh Kumar Nath added 7 commits November 6, 2018 23:47

Updated tests for kernel gateway

16fd75b

Merge remote-tracking branch 'upstream/develop' into gh_407

d206448

Fixed test cases

0ad07a2

Renamed test files

ea8a0c7

Few PR feedbacks

17e24ee

Removed unused code

caed0d2

Added test for validate vote for kernel changes and fixed few compila…

40084b8

…tion warnings

schemar suggested changes Nov 7, 2018

View reviewed changes

0xsarvesh reviewed Nov 12, 2018

View reviewed changes

Deepesh Kumar Nath added 8 commits November 12, 2018 17:52

renamed function initializeKernelGateway to initialize

945ab5a

Added PR review comment changes

0249e99

Updated test case

a801343

PR review feedback changes

e781554

Removed updateKernel function

e053df0

Removed repeated code

e9e7656

Added comments and documentation in mock contracts

24184c6

Fixed typo

dd1f7c9

schemar suggested changes Nov 14, 2018

View reviewed changes

Deepesh Kumar Nath added 7 commits November 14, 2018 19:47

PR review changes

b1ccd3b

Using test data

b471082

Renamed function getMetaBlockHash to currentMetaBlockHash

ef4bd9c

Added AuxiliaryTransitionObjectInterface.sol and OriginTransitionObje…

7e4452b

…ctInterface.sol

Removed extra test code

45396ac

Renamed function updateMetaBlockHeight to updateMetaBlock

a79e6a2

Renamed MockKernelGateway to TestKernelGateway

bd29a0e

schemar reviewed Nov 15, 2018

View reviewed changes

Deepesh Kumar Nath added 3 commits November 15, 2018 19:41

Contracts now include interfaces

ea3a336

Removed the onlyPollingPlace comment

6cbca6d

Updated comment for justify function

e4b3269

schemar approved these changes Nov 15, 2018

View reviewed changes

0xsarvesh approved these changes Nov 15, 2018

View reviewed changes

0xsarvesh merged commit eb77f01 into OpenST:develop Nov 15, 2018

hobofan mentioned this pull request Nov 19, 2018

Add initial version of genesis deployment tool #458

Merged

6 tasks

schemar mentioned this pull request Nov 23, 2018

New validators should join in K+1 #445

Closed

0xsarvesh mentioned this pull request Nov 29, 2018

OriginBlockStore should emit StateRootAvailable event on casper FFG finalization #501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kernel opening should be provable and confirmed on auxiliary #448

Kernel opening should be provable and confirmed on auxiliary #448

deepesh-kn commented Nov 5, 2018

schemar commented Nov 5, 2018

schemar left a comment

schemar left a comment

0xsarvesh left a comment

schemar left a comment

schemar left a comment

schemar left a comment

0xsarvesh left a comment

Kernel opening should be provable and confirmed on auxiliary #448

Kernel opening should be provable and confirmed on auxiliary #448

Conversation

deepesh-kn commented Nov 5, 2018

schemar commented Nov 5, 2018

schemar left a comment

Choose a reason for hiding this comment

schemar left a comment

Choose a reason for hiding this comment

0xsarvesh left a comment

Choose a reason for hiding this comment

schemar left a comment

Choose a reason for hiding this comment

schemar left a comment

Choose a reason for hiding this comment

schemar left a comment

Choose a reason for hiding this comment

0xsarvesh left a comment

Choose a reason for hiding this comment