Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better presets #7

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Better presets #7

wants to merge 27 commits into from

Conversation

Wueffi
Copy link

@Wueffi Wueffi commented Jul 14, 2024

This adds the birdflop presets and some player presets to the plugin and organizes them in a different (better) way.

/nick presets <pride|birdflop|players>

Copy link
Member

@Nickster258 Nickster258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the idea of categorizing types of presets separately. It makes seeing the available presets much less cluttered.

I added comments regarding this specific implementation and how it can be easily modified for future categories. Also a comment on how this implementation ignores the config file when loading, which would have to be fixed so that we can make changes in the config that get loaded by the proxy.

src/main/kotlin/birdflop-presets.kt Outdated Show resolved Hide resolved
src/main/kotlin/birdflop-presets.kt Outdated Show resolved Hide resolved
src/main/kotlin/commands/Nick.kt Outdated Show resolved Hide resolved
src/main/kotlin/commands/Nick.kt Outdated Show resolved Hide resolved
src/main/kotlin/birdflop-presets.kt Outdated Show resolved Hide resolved
src/main/kotlin/player-presets.kt Outdated Show resolved Hide resolved
src/main/kotlin/entity/ChattORESpec.kt Outdated Show resolved Hide resolved
@Wueffi Wueffi requested a review from Nickster258 July 15, 2024 05:49
@Wueffi
Copy link
Author

Wueffi commented Jul 15, 2024

@Nickster258 do you wanna take a look at it? I updated the chattorespec and nick.kt to fit the yaml config structure

@Wueffi
Copy link
Author

Wueffi commented Jul 15, 2024

Also i accidently clicked on review nickstore this morning 0.o but you can take a look at it now :]

src/main/kotlin/entity/ChattORESpec.kt Outdated Show resolved Hide resolved
src/main/kotlin/birdflop-presets.kt Outdated Show resolved Hide resolved
src/main/kotlin/birdflop-presets.kt Outdated Show resolved Hide resolved
src/main/kotlin/player-presets.kt Outdated Show resolved Hide resolved
src/main/kotlin/commands/Nick.kt Outdated Show resolved Hide resolved
src/main/kotlin/player-presets.kt Outdated Show resolved Hide resolved
@Wueffi Wueffi requested a review from Nickster258 July 19, 2024 08:10
@Wueffi
Copy link
Author

Wueffi commented Jul 19, 2024

I think I added all req. changes while keeping the structure you wanted :]

btw I combined the 3 preset files into 1 file but kept the togradient function in the config file.

how did I write arrrayOF i wasnt even drunk or smth

Yes ik beautiful commit message
Copy link
Member

@Nickster258 Nickster258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would help tremendously to review this if you were testing / compiling them yourself. As it currently stands, this PR doesn't build.

src/main/kotlin/presets.kt Outdated Show resolved Hide resolved
src/main/kotlin/entity/ChattORESpec.kt Outdated Show resolved Hide resolved
src/main/kotlin/entity/ChattORESpec.kt Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants