-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better presets #7
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like the idea of categorizing types of presets separately. It makes seeing the available presets much less cluttered.
I added comments regarding this specific implementation and how it can be easily modified for future categories. Also a comment on how this implementation ignores the config file when loading, which would have to be fixed so that we can make changes in the config that get loaded by the proxy.
@Nickster258 do you wanna take a look at it? I updated the chattorespec and nick.kt to fit the yaml config structure |
Also i accidently clicked on review nickstore this morning 0.o but you can take a look at it now :] |
I think I added all req. changes while keeping the structure you wanted :] btw I combined the 3 preset files into 1 file but kept the togradient function in the config file. |
how did I write arrrayOF i wasnt even drunk or smth Yes ik beautiful commit message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would help tremendously to review this if you were testing / compiling them yourself. As it currently stands, this PR doesn't build.
This adds the birdflop presets and some player presets to the plugin and organizes them in a different (better) way.
/nick presets <pride|birdflop|players>