Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix ch suggestions update #10323

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

SarahBellaha
Copy link
Contributor

Closes #10033

@SarahBellaha SarahBellaha requested a review from a team as a code owner January 10, 2025 15:21
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (ceb2468) to head (025c4e1).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10323      +/-   ##
==========================================
- Coverage   81.78%   81.78%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106578   106582       +4     
  Branches      731      731              
==========================================
+ Hits        87163    87166       +3     
- Misses      19376    19377       +1     
  Partials       39       39              
Flag Coverage Δ
editoast 74.21% <ø> (-0.01%) ⬇️
front 89.34% <66.66%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested 👍

@SarahBellaha SarahBellaha force-pushed the sba/front/fix-ch-suggestions-update branch from a1b9865 to 1944399 Compare January 16, 2025 08:09
@SarahBellaha SarahBellaha force-pushed the sba/front/fix-ch-suggestions-update branch from 1944399 to 025c4e1 Compare January 22, 2025 09:09
@SarahBellaha SarahBellaha requested a review from clarani January 22, 2025 12:28
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM because it fixes a major bug: if a user now selects a linked train, then the ci and ch are correctly set.

However, the management of the ch suggestions is still broken. It will be solved by this issue

@SarahBellaha SarahBellaha added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit 6b8bd15 Jan 23, 2025
27 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/fix-ch-suggestions-update branch January 23, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: selecting a linked train doesn't set the ch code
4 participants