-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix ch suggestions update #10323
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10323 +/- ##
==========================================
- Coverage 81.78% 81.78% -0.01%
==========================================
Files 1073 1073
Lines 106578 106582 +4
Branches 731 731
==========================================
+ Hits 87163 87166 +3
- Misses 19376 19377 +1
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested 👍
front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx
Outdated
Show resolved
Hide resolved
a1b9865
to
1944399
Compare
Signed-off-by: SarahBellaha <[email protected]>
1944399
to
025c4e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM because it fixes a major bug: if a user now selects a linked train, then the ci and ch are correctly set.
However, the management of the ch suggestions is still broken. It will be solved by this issue
Closes #10033