-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix git describe version injected to the frontend #10320
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10320 +/- ##
==========================================
- Coverage 81.60% 81.58% -0.03%
==========================================
Files 1067 1067
Lines 105535 105535
Branches 727 727
==========================================
- Hits 86126 86099 -27
- Misses 19368 19397 +29
+ Partials 41 39 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
96b3692
to
8903806
Compare
83fcd13
to
4a34ca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
4a34ca0
to
884d2ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! LGTM
Signed-off-by: Florian Amsallem <[email protected]>
884d2ae
to
02fc1db
Compare
development
when runningdocker compose ...
Example when pulling the image of this PR.
Warning
I did not test with the front end embedded with the gateway.