Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: create InfraObjectLayers to group all infra object layers #10318

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 10, 2025

See commits

@clarani clarani requested a review from a team as a code owner January 10, 2025 11:21
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (675d279) to head (a4049fa).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10318      +/-   ##
==========================================
- Coverage   81.64%   81.59%   -0.06%     
==========================================
  Files        1066     1067       +1     
  Lines      105735   105535     -200     
  Branches      727      727              
==========================================
- Hits        86328    86108     -220     
- Misses      19366    19386      +20     
  Partials       41       41              
Flag Coverage Δ
editoast 73.61% <ø> (-0.07%) ⬇️
front 89.30% <100.00%> (-0.04%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani self-assigned this Jan 10, 2025
@clarani clarani enabled auto-merge January 10, 2025 12:04
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice refacto 💯

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job !

@clarani clarani force-pushed the cni/refacto-layers branch 2 times, most recently from b5a4db9 to 2c3f4d6 Compare January 14, 2025 16:36
Harmonize these 2 layers with the others. Added a boolean overrides store to correctly handle the editor map, since these 2 layers are not in GeoJSON for the moment.

Signed-off-by: Clara Ni <[email protected]>
@clarani clarani force-pushed the cni/refacto-layers branch from 2c3f4d6 to a4049fa Compare January 15, 2025 13:35
@clarani clarani added this pull request to the merge queue Jan 15, 2025
Merged via the queue into dev with commit 4e1f461 Jan 15, 2025
27 checks passed
@clarani clarani deleted the cni/refacto-layers branch January 15, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants