-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: create InfraObjectLayers to group all infra object layers #10318
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10318 +/- ##
==========================================
- Coverage 81.64% 81.59% -0.06%
==========================================
Files 1066 1067 +1
Lines 105735 105535 -200
Branches 727 727
==========================================
- Hits 86328 86108 -220
- Misses 19366 19386 +20
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice refacto 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job !
b5a4db9
to
2c3f4d6
Compare
Harmonize these 2 layers with the others. Added a boolean overrides store to correctly handle the editor map, since these 2 layers are not in GeoJSON for the moment. Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
2c3f4d6
to
a4049fa
Compare
See commits