Fix bfloat16_bits union so that it always the sizeof unsigned short for AIX. #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless we packed the bfloat16_bits structure, it can be something besides the sizeof unsigned short (AKA 2). On AIX with OpenXLC, without this change the size is 4. |
|
Also ensure that the sizeof float32_bits is the sizeof float (AKA 4) |
|
I wonder how portable this attribute is ? |
This is is tested on powerpc Linux and AIX with gcc and Open XL C. We can protect this with ifdef AIX, if needed. |
|
Thanks. Either ifdef AIX or (I guess) ifndef MSVC would do then - bet Microsoft wants some #pragma here instead |
ChipKerchner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bfloat16_bits union so that it always the sizeof unsigned short for AIX.