Backend (users, ratings) #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apoorvgarg-creator
requested changes
Dec 31, 2022
backend/src/routes/ratings.js
Outdated
|
|
||
| router.get('/', async(req, res) => { | ||
| try{ | ||
| const ratings = await Rating.find() |
There was a problem hiding this comment.
Separate the controller and service logic.
There was a problem hiding this comment.
Name the route files as ratings.routes.js
backend/src/routes/users.js
Outdated
|
|
||
|
|
||
| router.get('/', async(req, res) => { | ||
| try{ |
There was a problem hiding this comment.
Same for this, Make a different controller and service
backend/src/routes/ratings.js
Outdated
|
|
||
|
|
||
| router.get('/', async(req, res) => { | ||
| try{ |
There was a problem hiding this comment.
Create an index.js file in routes to map routes
|
@Apoorvgarg-creator I have made the required changes, please review. |
@navyagarwal Let's have a meet later. I reviewed your changes but couldn't find the the service and controller logic separated. I will show you to do for one and also explain it you. But Good Work on PR ! Merging it for now but we will look into a different pattern |
Apoorvgarg-creator
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created model and (get, put, patch, delete) routes for:
- name
- email
- if management
- date
- user_id
- food_id
- stars
- tags
Improvements needed: