Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #586

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Fix CI #586

merged 3 commits into from
Nov 28, 2024

Conversation

chinwobble
Copy link
Contributor

Fix the broken CI.

  • add fail-fast: false. If ci on mac fails, it won't stop building on linux. This is useful to check if one builds but the other doesn't
  • Pin the image versions. macos-latest automatically updated to m1 mac on arm64 which was caused the CI to start failing
  • Pin the versions of the ubuntu-24.04 so that it doesn't automatically update and randomly fail when a new latest is released
  • Fix the ci trigger so that ci is always on pull requests
  • Fix the incremental builds header file changes are detected properly.

@sfchen sfchen merged commit 59cc2f6 into OpenGene:master Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants