Added custom message to ensure only one

[James-OpenGamma]

Summary by CodeRabbit

• New Features
  • Added a method to ensure no more than one matching element in a stream, with custom error messages for better clarity.

[jodastephen]

@coderabbitai review

[coderabbitai]

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

The changes introduce a new method ensureOnlyOne(String message, Object... args) in Guavate.java, which ensures there is no more than one matching element in a stream, throwing an IllegalArgumentException if more than one element is present. Additionally, a corresponding test method test_ensureOnlyOne_withCustomMessage is added to GuavateTest.java to validate this new functionality with a custom error message.

Changes

Files	Change Summaries
modules/collect/src/main/java/com/opengamma/strata/collect/Guavate.java	Added a new method ensureOnlyOne(String message, Object... args) to ensure no more than one matching element in a stream.
modules/collect/src/test/java/com/opengamma/strata/collect/GuavateTest.java	Added a new test method test_ensureOnlyOne_withCustomMessage to test the ensureOnlyOne method with a custom error message.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Client
    participant Guavate
    participant Stream

    Client->>Guavate: ensureOnlyOne("Error: %s", "duplicate found")
    Guavate->>Stream: process stream
    Stream-->>Guavate: more than one element
    Guavate-->>Client: IllegalArgumentException("Error: duplicate found")

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2c097d0 and 32436ac.

Files selected for processing (2)

• modules/collect/src/main/java/com/opengamma/strata/collect/Guavate.java (2 hunks)
• modules/collect/src/test/java/com/opengamma/strata/collect/GuavateTest.java (1 hunks)

[James-OpenGamma]

@jodastephen Pretty cool, a lot of noise though haha

I do like the summary it added to the PR description.

[jodastephen]

@coderabbitai resolve

[coderabbitai]

Actions performed

Comments resolved.