Add support for splitting contract specs and security IDs with hyphen ("-") in the contract code #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mistuus
requested review from
jodastephen,
beajeanm,
brianweller89 and
DaveBraithwaite-OG
and removed request for
brianweller89
Mistuus
commented
Nov 13, 2023
Comment on lines
+47
to
+51
| private static final Pattern SECURITY_ID_PATTERN = Pattern.compile(Messages.format( | ||
| "^(?<{}>.*){}(?<{}>.*)$", | ||
| CONTRACT_DETAILS_REGEX_GROUP_NAME, | ||
| GROUPS_SEPARATOR, | ||
| EXPIRY_AND_OPTION_DETAILS_GROUP_NAME)); |
There was a problem hiding this comment.
I tried making this as readable as possible so any other suggestions are more than welcome
jodastephen
approved these changes
Nov 13, 2023
Mistuus
added
auto-merge
jodastephen
approved these changes
Nov 13, 2023
sagiruthvik
pushed a commit
to SolumXplain/solum-xplain-opengamma-strata
that referenced
this pull request
Nov 13, 2024
… ("-") in the contract code (OpenGamma#2612)
* Add support for splitting contract spec ID when contract code has hyphen
* Add support for splitting contract codes with hyphen in the name
* Update javadoc comment
* Add XNSE as exchange and test for option with hyphen
---------
Co-authored-by: Victor Patentasu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
F-XNSE-BAJAJ-AUTO