PROD-29409: use getters everywhere

OpenGamma · Dec 18, 2023 · 36e36db · 36e36db
1 parent 60dd566
commit 36e36db
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/...oduct/src/main/java/com/opengamma/strata/product/swap/type/IborRateSwapLegConvention.java b/...oduct/src/main/java/com/opengamma/strata/product/swap/type/IborRateSwapLegConvention.java
@@ -496,10 +496,10 @@ public RateCalculationSwapLeg toLeg(
             .endDate(endDate)
             .frequency(getAccrualFrequency())
             .businessDayAdjustment(getAccrualBusinessDayAdjustment())
-            .startDateBusinessDayAdjustment(startDateBusinessDayAdjustment)
-            .endDateBusinessDayAdjustment(endDateBusinessDayAdjustment)
+            .startDateBusinessDayAdjustment(getStartDateBusinessDayAdjustment())
+            .endDateBusinessDayAdjustment(getEndDateBusinessDayAdjustment())
             .stubConvention(getStubConvention())
-            .rollConvention(rollConvention)
+            .rollConvention(getRollConvention())
             .build())
         .paymentSchedule(PaymentSchedule.builder()
             .paymentFrequency(getPaymentFrequency())
@@ -508,11 +508,11 @@ public RateCalculationSwapLeg toLeg(
             .build())
         .notionalSchedule(NotionalSchedule.builder()
             .currency(getCurrency())
-            .finalExchange(notionalExchange)
-            .initialExchange(notionalExchange)
+            .finalExchange(isNotionalExchange())
+            .initialExchange(isNotionalExchange())
             .amount(ValueSchedule.of(notional)).build())
         .calculation(IborRateCalculation.builder()
-            .index(index)
+            .index(getIndex())
             .dayCount(getDayCount())
             .fixingRelativeTo(getFixingRelativeTo())
             .fixingDateOffset(getFixingDateOffset())

diff --git a/...t/src/test/java/com/opengamma/strata/product/swap/type/IborRateSwapLegConventionTest.java b/...t/src/test/java/com/opengamma/strata/product/swap/type/IborRateSwapLegConventionTest.java
@@ -16,6 +16,7 @@
 import static com.opengamma.strata.basics.schedule.Frequency.P3M;
 import static com.opengamma.strata.basics.schedule.Frequency.P6M;
 import static com.opengamma.strata.basics.schedule.StubConvention.LONG_INITIAL;
+import static com.opengamma.strata.basics.schedule.StubConvention.SMART_INITIAL;
 import static com.opengamma.strata.collect.TestHelper.assertSerialization;
 import static com.opengamma.strata.collect.TestHelper.coverBeanEquals;
 import static com.opengamma.strata.collect.TestHelper.coverImmutableBean;
@@ -152,6 +153,10 @@ public void test_toLeg() {
             .startDate(startDate)
             .endDate(endDate)
             .businessDayAdjustment(BDA_MOD_FOLLOW)
+            .startDateBusinessDayAdjustment(BDA_MOD_FOLLOW)
+            .endDateBusinessDayAdjustment(BDA_MOD_FOLLOW)
+            .rollConvention(RollConventions.EOM)
+            .stubConvention(SMART_INITIAL)
             .build())
         .paymentSchedule(PaymentSchedule.builder()
             .paymentFrequency(P3M)
@@ -178,6 +183,10 @@ public void test_toLeg_withSpread() {
             .startDate(startDate)
             .endDate(endDate)
             .businessDayAdjustment(BDA_MOD_FOLLOW)
+            .startDateBusinessDayAdjustment(BDA_MOD_FOLLOW)
+            .endDateBusinessDayAdjustment(BDA_MOD_FOLLOW)
+            .rollConvention(RollConventions.EOM)
+            .stubConvention(SMART_INITIAL)
             .build())
         .paymentSchedule(PaymentSchedule.builder()
             .paymentFrequency(P3M)