Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename subject path to '@id' #206 #214

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Rename subject path to '@id' #206 #214

merged 4 commits into from
Nov 12, 2024

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Nov 8, 2024 •
edited by jh-RLI
Loading

Summary of the discussion

The IRI are not just a path but a proper identifier.
This should be indicated by @id.

Type of change (CHANGELOG.md)

Updated

  • Rename URI from path to @id (#214)

Workflow checklist

Automation

Closes #206

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature labels Nov 8, 2024
@Ludee Ludee requested a review from jh-RLI November 8, 2024 14:04
@Ludee Ludee self-assigned this Nov 8, 2024
@Ludee Ludee changed the title Rename subject path to '@id' Rename subject path to '@id' #206 Nov 11, 2024
@Ludee Ludee marked this pull request as ready for review November 11, 2024 13:38
jh-RLI
jh-RLI approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ludee Ludee merged commit edd5f5e into develop Nov 12, 2024
2 checks passed
@Ludee Ludee deleted the feature-206-id branch November 12, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jh-RLI jh-RLI jh-RLI approved these changes

Assignees

@Ludee Ludee

Labels
part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The name of the keys for the IRI should be "@id" instead of "path"
2 participants
@Ludee @jh-RLI