Fix: Cycle time change from wait for trigger to actual time #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parapluplu
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2790 +/- ##
==============================================
- Coverage 56.65% 25.85% -30.80%
==============================================
Files 2167 262 -1905
Lines 91939 6682 -85257
Branches 6833 1026 -5807
==============================================
- Hits 52081 1727 -50354
+ Misses 37983 4876 -33107
+ Partials 1875 79 -1796 |
If the config was changed from `AbstractWorker.ALWAYS_WAIT_FOR_TRIGGER_NEXT_RUN` to a value >= 0 again the cycle thread remaind in a waiting state. The reason for that is that the thread was put in an await state as soon as `AbstractWorker.ALWAYS_WAIT_FOR_TRIGGER_NEXT_RUN` was configured. This change allows a change at releases the thread again. Testing: Unit tests, and the simulator app starts up and starts executing cycles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the config was changed from
AbstractWorker.ALWAYS_WAIT_FOR_TRIGGER_NEXT_RUNto a value >= 0 again the cycle thread remaind in a waiting state. The reason for that is that the thread was put in an await state as soon asAbstractWorker.ALWAYS_WAIT_FOR_TRIGGER_NEXT_RUNwas configured.This change allows a change at releases the thread again.
Testing: Unit tests, and the simulator app starts up and starts executing cycles
Note: The cycle worker implementation is using a stopwatch that does not allow to inject a custom clock. To improve unit tests, I can provide a pull request that refactors the stopwatch implementation first, if this change is wanted.
This change fixes an error that surfaces when using the SimulatorApp. The cycle never actually starts to execute.