Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show preview banner on /results (when previewing a non-master branch) #184

Merged
merged 3 commits into from
Jan 18, 2018

Conversation

andylolz
Copy link
Contributor

@andylolz andylolz commented Nov 14, 2017

Refs #183.

This doesn’t solve #183, because:

  • it’s only /results – not /about or /terms
  • it looks a bit ugly because of the fixed position sidebar (I wonder if absolute positioning would be better?) UPDATE: I added a commit to absolutely position the sidebar, which makes the banner look roughly correct. I don’t thiiiink this breaks old browsers… but it might.

@andylolz andylolz changed the title Add branch to context on /results Show preview banner on /results (when previewing a non-master branch) Nov 14, 2017
@Bjwebb Bjwebb merged commit 35519dd into OpenDataServices:master Jan 18, 2018
@andylolz andylolz deleted the 183-preview-banner branch January 18, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants