Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 and jsonschema 3 #129

Closed
wants to merge 1 commit into from
Closed

Drop support for Python 3.6 and jsonschema 3 #129

wants to merge 1 commit into from

Conversation

jpmckinney
Copy link
Contributor

@jpmckinney jpmckinney commented Jul 11, 2023

This along with #128 is an easier-to-merge alternative to #123. It will give lib-cove-ocds the flexibility it needs to (1) use the latest jsonschema and (2) not see deprecation warnings.

@odscjames
Copy link
Collaborator

Python 3.6 (and 3.7) support dropped and merged in #132

@odscjames
Copy link
Collaborator

Can you comment on the reasons for dropping JSONSchema 3 (beyond v3 hasn't been released since 2019)? Unfortunately it looks like it's pinned in 360 so we'll need to dig more into this one. https://github.com/ThreeSixtyGiving/dataquality/blame/42fc01837490083c852c99eec66020e854cd30db/setup.py#L18

@jpmckinney
Copy link
Contributor Author

It becomes difficult to support both major versions of jsonschema.

Maybe try unpinning in 360?

Only consequence of merging is 360 effectively pins lib-cove until jsonschema is unpinned.

@michaelwood
Copy link
Member

For reference this is the commit in 360Giving from a recent PR ThreeSixtyGiving/dataquality@0627357

I'm not very familiar with libcove, but 360Giving's cove could always pin to a compatible version of lib-cove for a time? The only request is that an upgrade path is possible.

@jpmckinney
Copy link
Contributor Author

I think that incompatibility was fixed by cf97ed8

As I suggested, try unpinning - it’ll probably Just Work.

@odscjames
Copy link
Collaborator

Dropped in #133

@odscjames odscjames closed this Oct 10, 2023
@jpmckinney jpmckinney deleted the jsonschema-4-deprecation branch October 10, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants