-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Calculate additional codelist values for schema using anyOf, like OCDS record packages #125
Closed
jpmckinney
wants to merge
5
commits into
OpenDataServices:main
from
jpmckinney:anyof-additional-codes
Closed
fix: Calculate additional codelist values for schema using anyOf, like OCDS record packages #125
jpmckinney
wants to merge
5
commits into
OpenDataServices:main
from
jpmckinney:anyof-additional-codes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmckinney
changed the title
fix: Calculate additional codelist values for schema using anyOf, like OCDS record packages open-contracting/lib-cove-ocds#106
fix: Calculate additional codelist values for schema using anyOf, like OCDS record packages
Jul 10, 2023
jpmckinney
added a commit
to open-contracting/lib-cove-ocds
that referenced
this pull request
Jul 10, 2023
…S record packages
Do you have any simple sample data handy we can turn into a test? Thanks. |
Sample data was in the linked issue, but I just committed the test instead. |
odscjames
pushed a commit
that referenced
this pull request
Nov 8, 2023
odscjames
pushed a commit
that referenced
this pull request
Nov 8, 2023
odscjames
pushed a commit
that referenced
this pull request
Nov 8, 2023
odscjames
pushed a commit
that referenced
this pull request
Nov 8, 2023
Replaced by #137 |
odscjames
pushed a commit
that referenced
this pull request
Nov 23, 2023
… like OCDS record packages #125 open-contracting/lib-cove-ocds#106
odscjames
pushed a commit
that referenced
this pull request
Nov 23, 2023
… like OCDS record packages #125 open-contracting/lib-cove-ocds#106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-contracting/lib-cove-ocds#106
Diff is smaller if ignoring whitespace: https://github.com/OpenDataServices/lib-cove/pull/125/files?w=1