Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Start database page with table names #60

Merged
merged 2 commits into from
May 11, 2018
Merged

Start database page with table names #60

merged 2 commits into from
May 11, 2018

Conversation

odscjames
Copy link
Contributor

Well ....

I have no strong reasons to argue that they should be singular - it's just always seemed clearer. You tend to deal with rows one at a time, and so the name should reflect what one row of a table is. For instance, if you have a table of cars each row is one car, so the table should be called "car". If dealing with a system where models mirror table names, you want the model to be "Car" to.

But I accept that is really getting down to a preference. If you all tell me plural, so be it :-)

@BibianaC
Copy link
Member

BibianaC commented May 4, 2018

+1 for singular for exactly what @odscjames says. If a model name is singular, it makes sense that the db table is also singular.
I also don't have a strong opinion about it.

Copy link
Member

@Bjwebb Bjwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this, but would be even better if we noted that this is Django's default behaviour.

@odscjames
Copy link
Contributor Author

but would be even better if we noted that this is Django's default behaviour.

So I'm guessing your comment on #63 would be "yes"?

@odscjames
Copy link
Contributor Author

On merging this particular P.R., I'll tag @kindly and give him a few days to see if he wants to comment first ...

@odscjames odscjames merged commit 9cedd95 into master May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants