Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call memory.deallocate for NULL memory #59

Merged
merged 10 commits into from
Aug 16, 2024
Merged

Conversation

serges147
Copy link
Contributor

@serges147 serges147 commented Aug 16, 2024

Also:

  • Latest toolshed:ts22.4.3 -> 22.4.10 : gcc 11.3 -> 12.3
  • Disable some new clang-tidies

@serges147 serges147 self-assigned this Aug 16, 2024
@serges147 serges147 marked this pull request as ready for review August 16, 2024 12:42
.clang-tidy Outdated
@@ -22,6 +22,10 @@ Checks: >-
-hicpp-static-assert,
-misc-static-assert,
-modernize-macro-to-enum,
-cppcoreguidelines-macro-to-enum,-warnings-as-errors,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-cppcoreguidelines-macro-to-enum,-warnings-as-errors,
-cppcoreguidelines-macro-to-enum,
-warnings-as-errors,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copy/paste error actually - there should be no "-warnings-as-errors,"

@pavel-kirienko
Copy link
Member

Please bump the patch version

Copy link

@serges147 serges147 merged commit 3d9f5ef into main Aug 16, 2024
23 checks passed
@serges147 serges147 deleted the sshirokov/memFree_NULL branch August 16, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants