Bump HDF5 build version on the Mac #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjh1
force-pushed
the
mac-hdf5-version
branch
10 times, most recently
from
021ba3a to
a36097d
Compare
cjh1
force-pushed
the
mac-hdf5-version
branch
from
a36097d to
071d225
Compare
The default install of h5py on the Mac is built again HDF5 1.12. stempy was being built against 1.10 so we were getting missing symbols at runtime.
cjh1
force-pushed
the
mac-hdf5-version
branch
from
071d225 to
514ef2b
Compare
cjh1
changed the title
|
Were these changes specifically for arm64, x86_64, or both? |
|
For both, although I don't have access to a x86_64 mac to test with. |
psavery
approved these changes
Oct 27, 2023
|
Thanks @psavery for the review and testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.