-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export targets and config file #283
Conversation
|
This supports external projects linking against stempy.
The clean up of includes in image.h revealed that these headers were being included transitively.
I was getting a bunch of strange warnings in my build after running:
I tried to minimize my configuration to just find a couple packages including stempy:
This outputs:
Commenting out find_package Can you reproduce this? |
cmake/stempyConfig.cmake.in
Outdated
|
||
find_package(Python3 REQUIRED COMPONENTS Development) | ||
|
||
include_directories("${CMAKE_CURRENT_SOURCE_DIR}/stempy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is where my issue is coming from. ${CMAKE_CURRENT_SOURCE_DIR} is not the same in the CMakeLists that imports. I removed both lines in a test branch here and things still work. I believe the targets should hold this information, right?
@swelborn I have added an extra target include directory so that we can remove the |
This adds support for building against stempy, either a build tree or install tree.