-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues #258 and #259 #260
Conversation
Looks like I just need to update a unit mask in the ABFE restraint code in the Sandpit. Will fix on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - I like how pow has let you remove special case code elsewhere. Nice use of rounding. I need to remember to port this down into sire too.
Good unit tests :-)
Thanks. Yes, this simplified a lot of stuff elsewhere so it was worth doing, regardless of whether it will be needed in the long term. |
The merge-base changed after approval.
This PR...
closes [BUG] Ions should be excluded in AMBER position restraint mask #258 by excluding the standard free ions (Na and Cl) to the AMBER position restraint mask. This logic is triggered when the manual restraint mask exceeds the mask character limit, so we need to fall back on the assumption of standard AMBER atom naming. This will work in the case of a BioSImSpace workflow, e.g. where solvation is performed with BioSimSpace, but not for arbitrary input. (The restraint is unreliable then anyway.)
closes [BUG] The __pow__ operator for BioSimSpace.Types._GeneralUnit doesn't handle fractional exponents #259 by adding support for fractional exponents in the
BioSimSpace.Types._GeneralUnit.__pow__
operator. I've also re-orded the dimension mask used internally for consistency with sire, which will make it easier to createGeneralUnit
types from these masks. (I hadn't used this before.) These update is largely covered by the existing tests but I've added a further test specific to fractional exponents to cover a range of cases, including error handling.devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]Suggested reviewers:
@chryswoods