Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] FMP - Fix missing exchange choices in equity.screener #7008

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Jan 23, 2025

  1. Why?:

    • The defined choices for the exchange param in, equity.screener(provider="fmp"), was not fully populating.
    • UnauthorizedError not raised in, equity.fundamental.transcripts.
  2. What?:

    • UnauthorizedError now raises when an invalid API key is used for earnings transcripts.
    • All exchange choices added to __json_schema_extra__, and now populate correctly.
    • Removes "conglomerates" as a sector choice - returns nothing from FMP.
  3. Impact (1-2 sentences or a bullet point list):

    • Fixes missing choices presented by openbb-api
    • More clarity for users by raising UnauthorizedError
  4. Testing Done:

    • Free/bad API key.

Exchange choices after:

Screenshot 2025-01-23 at 9 51 21 AM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jan 23, 2025
@deeleeramone deeleeramone requested a review from piiq January 23, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant