feat: definition and implementation of the incrbyfloat command #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panlei-coder
reviewed
Dec 5, 2023
| int StrToLongDouble(const char* s, size_t slen, long double* ldval) { | ||
| char* pEnd; | ||
| std::string t(s, slen); | ||
| if (t.find(' ') != std::string::npos) { |
There was a problem hiding this comment.
感觉这里的判断应该不需要吧，你在后面已经判断了转换的pEnd是否等于字符串的长度了，这里应该冗余了
There was a problem hiding this comment.
我觉得还是留着比较好，因为我看了strtold这个函数，它可能会在遇到空格时停止转换，并返回到目前为止已经转换的数字，比如1 23.45就会变成1.0，我并不希望发生这样的事情。
举个例子，我在执行incrbyfloat test 123.45的时候因为某些原因输入成了incrbyfloat test 12 3.45，这时候test会增加12.0, 不能达到命令的预期，所以我觉得这里也是个防呆操作，只要字符串含有空格就直接抛出-1提示转换失败会更好
There was a problem hiding this comment.
其实这个参数检查的时候应该就会检查出来吧 只接受3个参数，结果传了4个参
There was a problem hiding this comment.
但是我觉得这个是公共方法，不是只有incrbyfloat这一个命令用到，我觉得严谨一点会更好
AlexStocks
reviewed
Dec 6, 2023
AlexStocks
reviewed
Dec 6, 2023
AlexStocks
previously approved these changes
Dec 9, 2023
AlexStocks
reviewed
Dec 9, 2023
src/cmd_kv.cc
Outdated
| } | ||
|
|
||
| void IncrbyfloatCmd::DoCmd(PClient* client) { | ||
| std::string new_value_; |
AlexStocks
reviewed
Dec 9, 2023
AlexStocks
reviewed
Dec 9, 2023
AlexStocks
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31
definition and implementation
incrbyfloatcommand, passed local testing.Execution result: