Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: clang format #55

Closed

Conversation

longfar-ncy
Copy link
Collaborator

No description provided.

src/pikiwidb_logo.h Outdated Show resolved Hide resolved
@longfar-ncy longfar-ncy reopened this Nov 27, 2023
@longfar-ncy
Copy link
Collaborator Author

.cc文件可能是之前已经被格式化过,这次改动仅包含.h头文件。
clang-format把所有头文件文件最后的空行都给删了,源文件可能之前被格式化过,本身没有最后一行,这个问题暂时还没找到解决方案

AlexStocks
AlexStocks previously approved these changes Nov 27, 2023
@AlexStocks
Copy link
Contributor

.cc文件可能是之前已经被格式化过,这次改动仅包含.h头文件。 clang-format把所有头文件文件最后的空行都给删了,源文件可能之前被格式化过,本身没有最后一行,这个问题暂时还没找到解决方案

format 检测,能否放到 github ci 检测里面?

@longfar-ncy
Copy link
Collaborator Author

.cc文件可能是之前已经被格式化过,这次改动仅包含.h头文件。 clang-format把所有头文件文件最后的空行都给删了,源文件可能之前被格式化过,本身没有最后一行,这个问题暂时还没找到解决方案

format 检测,能否放到 github ci 检测里面?

我试试

@longfar-ncy
Copy link
Collaborator Author

.cc文件可能是之前已经被格式化过,这次改动仅包含.h头文件。 clang-format把所有头文件文件最后的空行都给删了,源文件可能之前被格式化过,本身没有最后一行,这个问题暂时还没找到解决方案

搞错了,clang-format.py脚本不检测*.cc,现已修复

@longfar-ncy longfar-ncy deleted the style/format branch November 27, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants