Merge 'context' and 'client' #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveyacper
reviewed
Nov 13, 2023
| ret_ = kNone; | ||
| } | ||
|
|
||
| inline std::string Message() const { return message_; }; |
There was a problem hiding this comment.
好的. 我在写的时候,想的通过inline, 调用这个函数, 是不是和直接 .message_ 效果是一样的了, 所以就直接返回 string了
There was a problem hiding this comment.
好的. 我在写的时候,想的通过inline, 调用这个函数, 是不是和直接 .message_ 效果是一样的了, 所以就直接返回 string了
测试了一下目前这样写必定 copy，gcc version 8.4.1, O2优化。
There was a problem hiding this comment.
好的. 我在写的时候,想的通过inline, 调用这个函数, 是不是和直接 .message_ 效果是一样的了, 所以就直接返回 string了
测试了一下目前这样写必定 copy，gcc version 8.4.1, O2优化。
多谢, 今晚回去改一下
loveyacper
approved these changes
Nov 13, 2023
AlexStocks
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
把之前的
Context和Client这两个合并了,只保留了Client. 每次执行命令,通过一个client来传递 命令中的 上下文数据把现阶段没有用到的一些功能先去掉(想的是先简化代码,后面根据需要再添加,不要一开始就是背负着历史包袱)
修改了Redis协议的解析和编码函数
简化数据处理流程,,现在去掉了C风格的处理命令的入口
这次改动有点大,步子迈的有点大,请帮忙多检查,多指正
像是接收到数据,解析Redis协议那部分, 我感觉改的还是不够好,但是感觉还是没有改到我理想的那样. 我原来想的是每个模块的功能划分好, 不要相互耦合, 现在 协议解析还是和
Client有关联, 如果有好的实现方式,欢迎指教