Full file:// syntax support
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feltech
changed the title
file:// syntax supportfile:// syntax support
feltech
force-pushed
the
work/14-urlHandling
branch
4 times, most recently
from
0929e55
to
c29f67e
Compare
elliotcmorris
requested changes
Jun 13, 2024
Part of OpenAssetIO#14. Fix `catchAndLogExceptions` to remove the mitigation against bad RTTI behaviour in OpenAssetIO exceptions. This was fixed upstream in OpenAssetIO/OpenAssetIO#1225. Signed-off-by: David Feltell <[email protected]>
Part of OpenAssetIO#14. Remove unnecessary public header. The resolver plugin is never `#include`d as an external library, so having a public header just confuses matters. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/14-urlHandling
branch
from
c29f67e
to
cff78c3
Compare
Closes OpenAssetIO#14. Fully support `file` URLs by making use the OpenAssetIO `FileUrlPathConverter` utility. The utility will throw on non-`file` URLs being provided, maintaining existing behaviour (with a slightly different error message). Confirmed with manual testing. The `FileUrlPathConverter` utility is only available as of OpenAssetIO 1.0.0-beta.2.0. So update README. Signed-off-by: David Feltell <[email protected]>
Part of OpenAssetIO#14. A few minor tweaks highlighted by Clang-Tidy - a few `final` and `const`. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/14-urlHandling
branch
from
cff78c3
to
60b70f6
Compare
elliotcmorris
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14. Fully support
fileURLs by making use the OpenAssetIOFileUrlPathConverterutility.Also do a little refactoring to pimpl.
Additionally, we seemed to have lost the revert commit that removed the mitigation of OpenAssetIO/OpenAssetIO#1225, so update the exception catching to once again catch
std::exception.