Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1385 Generate constants for path in spring boot @RequestMapping #19782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bilak
Copy link
Contributor

@bilak bilak commented Oct 4, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

closes #1385

@martin-mfg
Copy link
Contributor

Hi @bilak, thanks for the PR!

Instead of introducing a new lambda "lambda.camelCaseToSnakeCase", would it work to use the already existing "lambda.snakecase"?

And could you take care of the failing tests please?

@bilak bilak force-pushed the feature/1385-geneate-constants-for-paths branch 2 times, most recently from 4e3fd6f to 8a8b74e Compare October 24, 2024 15:34
@bilak
Copy link
Contributor Author

bilak commented Oct 24, 2024

@martin-mfg I'm not sure if I rebased somehow wrong or why 5k files is in this commit. I reverted back my custom lambda and fixed the test...let me know if I should do something additionally

@bilak bilak force-pushed the feature/1385-geneate-constants-for-paths branch from 8a8b74e to 4e3a3ba Compare October 24, 2024 15:41
@bilak
Copy link
Contributor Author

bilak commented Oct 24, 2024

I've seen also this one I've tried that route but there are some issues in some codegen which I honestly don't udnerstand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPRING] Create constants for paths
2 participants