Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the blog bilingual #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mublin
Copy link

@Mublin Mublin commented Oct 26, 2022

Arabic version of the website was needed in Task 6

  • I added Arabic nav item in the navigation items.
  • I added href to the nav item leading the user to the _site/ar/ directory where the user will find arabic version index.html
  • I got the _site files( index.html, about.html) of the ar-blog and pasted it in the _site/ar/ directory
  • I tested it locally on my machine and it works on Rstudio
  • I fixed some images
  • I also gave my time using netlify to see why my PR were not working it turns out the netlify deployment were not working with the docs directory @alswajiab @BatoolMM
  1. I think the reviewer should check the _site folder to see how the _site/ar files are set up and for deployment, the user should make sure netlify works with both the _site directory and the _site/ar/ directory to achieve the bilingual website @okerekechinweotito
  2. If there is a way to make netlify work with _site/ar/ then we will achieve the bilingual website.
  3. The reviewer should not delete the arabic repo because it will be key to adding more contents because we need the _site files generated by Quarto and replace them in the _site/ar/ directory

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for oscsa-en-blog ready!

Name Link
🔨 Latest commit 94e68ad
🔍 Latest deploy log https://app.netlify.com/sites/oscsa-en-blog/deploys/6359c033f44f6a000836fe21
😎 Deploy Preview https://deploy-preview-35--oscsa-en-blog.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@BatoolMM
Copy link
Member

BatoolMM commented Nov 3, 2022

Thank you @Mublin for your work. HTML files shouldn't be changed, this is generated automatically from .qmd files.

@BatoolMM BatoolMM changed the title B1 task #6 Make the blog bilingual Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants