-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Activity Tracker with theme support, add functionality to delete entries #1430
Open
tGecko
wants to merge
15
commits into
main
Choose a base branch
from
feat-activity-tracker-delete-entries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tool in tweaks to reset hidden entries Add migration script to add the necessary column for this
Add some comments
fix item numbers not updating when on last page fix some not free'd variables slight refactoring
add timer.h add accelerated scroll on button hold fix memory leak in file_cleanName
tGecko
changed the title
Add functionality to delete entries in Activity Tracker
Rewrite Activity Tracker to use themes, add functionality to delete entries
Feb 18, 2024
….com/OnionUI/Onion into feat-activity-tracker-delete-entries
tGecko
changed the title
Rewrite Activity Tracker to use themes, add functionality to delete entries
Rewrite Activity Tracker with theme support, add functionality to delete entries
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added theming, implemented scrolling through items and deletion of entries in activity tracker.
|
Items are deleted by setting the new column roms.deletion_id for the selected item to the highest corresponding play_activity rowid.
Added a tool to restore deleted items to Tweaks
Added a migration script to add the roms.deletion_id column if necessary.
Closes #1326
TODO:
deletion_id
column (GameSwitcher.. ?)Testing:
Test the migration script
Test deleting items
Test restoring deleted items