Add v1.3.0 package updates #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nan-li
reviewed
Jan 14, 2025
sherwinski
force-pushed
the
api
branch
4 times, most recently
from
6d25387 to
efd98b4
Compare
nan-li
reviewed
Jan 16, 2025
| @@ -158,7 +158,7 @@ public okhttp3.Call beginLiveActivityCall(String appId, String activityId, Begin | |||
| Map<String, Object> localVarFormParams = new HashMap<String, Object>(); | |||
|
|
|||
| // Adds client sdk version header | |||
| localVarHeaderParams.put("OS-Usage-Data", "kind=sdk, sdk-name=onesignal-java, version=1.2.2"); | |||
| localVarHeaderParams.put("OS-Usage-Data", "kind=sdk, sdk-name=onesignal-java, version=2.1.0"); | |||
There was a problem hiding this comment.
With the change to use 1.3.0 as the release version, we just have to note that 2.1.0 java is 1.3.0, or change this here.
There was a problem hiding this comment.
Also if it looks ok, I updated the PR title
There was a problem hiding this comment.
I'm ok with this change because it's not user-impacting. Are you saying that we should either change this back or just internally note what it maps to?
nan-li
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One Line Summary
Syncs repo with API v1.3.0 changes. Includes the following:
deleteUserCallhttps://api.onesignal.com/