Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openapi definition should define usage of app_key #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romulus-ai
Copy link

Description

One Line Summary

Add usage of app_key also in the deleteUser function, otherwise deleteUser will always result in 403 error.

Details

Motivation

Fixing bug #35 opened by me, causing users could not be deleted, causing no compliance with GDPR

Scope

Being GDPR compliant when using OneSignal from Java.

Testing

Manual testing

Simply created a user and deleted it again, on success the patch works.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@romulus-ai
Copy link
Author

An Hint, This only fixes your OpenAPI Definition, the code must also be generated after merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant