Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iam/remove iam caching #1499

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Iam/remove iam caching #1499

merged 1 commit into from
Oct 24, 2024

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Oct 15, 2024

Description

One Line Summary

Removes IAM caching (follow up on #1486).

Details

We should not cache IAMs since it is incongruent with RYW consistency.

Example: there is an IAM targeting users on version 1.0. The user upgrades to 2.0 & should no longer see the IAM targeting 1.0.

The source of truth is the backend & we should only show IAMs as calculated by segment membership.

Testing

Manual testing

Tested in simulator with an IAM that shows on app certain versions.

Additional scenarios:

  • tested every time conditions are satisfied
  • tested with trigger

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
    • Only removing code. No existing coverage.
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@rgomezp rgomezp changed the base branch from main to consistency-manager October 15, 2024 21:10
@rgomezp rgomezp force-pushed the consistency-manager branch from 10e877b to ed9343e Compare October 16, 2024 17:05
@rgomezp rgomezp force-pushed the iam/remove-iam-caching branch from 1068348 to e7c2cb1 Compare October 16, 2024 20:35
@rgomezp rgomezp force-pushed the consistency-manager branch from 9c404e7 to 66dc1cd Compare October 16, 2024 23:12
@rgomezp rgomezp force-pushed the iam/remove-iam-caching branch from e7c2cb1 to 97f4778 Compare October 16, 2024 23:12
@rgomezp rgomezp force-pushed the consistency-manager branch from 66dc1cd to 279cce6 Compare October 18, 2024 22:48
@rgomezp rgomezp force-pushed the iam/remove-iam-caching branch from 97f4778 to 64161b1 Compare October 18, 2024 22:49
@rgomezp rgomezp force-pushed the consistency-manager branch from 32cf760 to 663edc1 Compare October 23, 2024 19:22
@rgomezp rgomezp force-pushed the iam/remove-iam-caching branch from 64161b1 to 92b0309 Compare October 23, 2024 19:34
Motivation: we should not cache IAMs since it is incongruent with RYW consistency.

Example: there is an IAM targeting users on version 1.0. The user upgrades to 2.0 & should no longer see the IAM targeting 1.0.

The source of truth is the backend & we should only show IAMs as calculated by segment membership.
@rgomezp rgomezp force-pushed the iam/remove-iam-caching branch from cf0e90f to 66354c0 Compare October 23, 2024 21:14
Base automatically changed from consistency-manager to main October 23, 2024 21:29
@rgomezp rgomezp requested a review from nan-li October 23, 2024 23:10
@rgomezp rgomezp merged commit bf8472f into main Oct 24, 2024
1 of 2 checks passed
@rgomezp rgomezp deleted the iam/remove-iam-caching branch October 24, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants