Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1076 : Replaced IntentService with JobIntentService in RealtimeService #1294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yashc18
Copy link

@yashc18 yashc18 commented Jan 22, 2025

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [] Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • [] If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

Changes Made :
Replace IntentService with JobIntentService in RealtimeService.java.

  • Replaced IntentService with JobIntentService in RealtimeService.java.
  • Replaced onHandleIntent method with onHandleWork method.
  • Updated start method to use enqueueWork method of JobIntentService.
  • Updated RealtimeService entry in AndroidManifest.xml to include android:permission attribute set to android.permission.BIND_JOB_SERVICE.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

@amrhossamdev amrhossamdev self-requested a review January 22, 2025 12:37
@amrhossamdev
Copy link
Member

Hi @yashc18 , thank you for your contributions. I'm testing it, and I will start the review!

@amrhossamdev amrhossamdev requested review from amrhossamdev and removed request for aaronbrethorst January 23, 2025 17:30
Copy link
Member

@amrhossamdev amrhossamdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Yash but JobIntentService is deprecated you should use Work Manager for that.

@amrhossamdev
Copy link
Member

Hi @yashc18, I am waiting for your response in Slack as we talked (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants