Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

long paths fix - add app.manifest to stdio driver #2298

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

long paths fix - add app.manifest to stdio driver #2298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6ba2e7
long paths fix - add app.manifest to stdio driver
Dec 7, 2021
f46bf55
Merge branch 'master' into bugfix/max-path-length
filipw Jan 6, 2022
88c1c7d
Merge branch 'master' into bugfix/max-path-length
Jun 7, 2022
05d9feb
Merge branch 'master' into bugfix/max-path-length
Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/OmniSharp.Stdio.Driver/OmniSharp.Stdio.Driver.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<OutputType>Exe</OutputType>
<PreserveCompilationContext>true</PreserveCompilationContext>
<RuntimeIdentifiers>win7-x64;win7-x86;win10-arm64</RuntimeIdentifiers>
<ApplicationManifest>app.manifest</ApplicationManifest>

<!-- Always run on the latest runtime installed. -->
<RuntimeFrameworkVersion>6.0.0-preview.7.21317.1</RuntimeFrameworkVersion>
Expand Down
17 changes: 17 additions & 0 deletions src/OmniSharp.Stdio.Driver/app.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>

<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<assemblyIdentity version="1.0.0.0" name="MyApplication.app"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an assemblyIdentity element? If so, should the version and name match the assembly generated by the OmniSharp.Stdio.Driver project?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeRobich The assemblyIdentity element is required - https://docs.microsoft.com/en-us/windows/win32/sbscs/application-manifests.

Okay, I'll look into how I get this apart of the build process

<trustInfo xmlns="urn:schemas-microsoft-com:asm.v2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the trustInfo section necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe it's necessary, I'll remove and re-submit

<security>
<requestedPrivileges xmlns="urn:schemas-microsoft-com:asm.v3">
<requestedExecutionLevel level="asInvoker" uiAccess="false"/>
</requestedPrivileges>
</security>
</trustInfo>
<application>
<windowsSettings xmlns:ws2="http://schemas.microsoft.com/SMI/2016/WindowsSettings">
<ws2:longPathAware>true</ws2:longPathAware>
</windowsSettings>
</application>
</assembly>